Skip to content

[Release-3.13] Address cluster update failure when old capacity reservation has been deleted #6883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025

Conversation

hehe7318
Copy link
Contributor

@hehe7318 hehe7318 commented Jun 16, 2025

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hehe7318 hehe7318 requested review from a team as code owners June 16, 2025 19:40
@hehe7318 hehe7318 added the 3.x label Jun 16, 2025
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.20%. Comparing base (960668b) to head (ee4f1b1).
Report is 28 commits behind head on release-3.13.

Files with missing lines Patch % Lines
cli/src/pcluster/config/cluster_config.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-3.13    #6883      +/-   ##
================================================
- Coverage         90.21%   90.20%   -0.02%     
================================================
  Files               181      181              
  Lines             16205    16208       +3     
================================================
+ Hits              14619    14620       +1     
- Misses             1586     1588       +2     
Flag Coverage Δ
unittests 90.20% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hehe7318 hehe7318 merged commit de0f66d into aws:release-3.13 Jun 16, 2025
24 of 26 checks passed
hgreebe pushed a commit to hgreebe/aws-parallelcluster that referenced this pull request Jun 19, 2025
…vation has been deleted (aws#6883)

* Do not error exit when capacity reservation from the existing cluster config has been deleted

* Improve integration test to test capacity reservation update without instance type specified

* Update changelog

---------

Co-authored-by: hanwenli <hanwenli@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants